Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ini config parsing to its own module #6838

Merged
merged 1 commit into from
May 16, 2019
Merged

Move ini config parsing to its own module #6838

merged 1 commit into from
May 16, 2019

Conversation

msullivan
Copy link
Collaborator

This is essentially in preparation for a proof-of-concept
implementation of #2938 I am working on, which will want to
call into this code from build, and a build -> main dependency
seems wrong.

@msullivan
Move ini config parsing to its own module
039af9d 
This is essentially in preparation for a proof-of-concept
implementation of #2938 I am working on, which will want to
call into this code from build, and a build -> main dependency
seems wrong.
@msullivan msullivan requested a review from gvanrossum May 15, 2019 21:27
@msullivan msullivan mentioned this pull request May 16, 2019
Merged
gvanrossum
gvanrossum approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@msullivan msullivan merged commit 6d34c04 into master May 16, 2019
@JelleZijlstra JelleZijlstra deleted the per-module-flags branch May 16, 2019 15:01
PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
@msullivan @PattenR
Move ini config parsing to its own module (python#6838)
936e9b1 
This is essentially in preparation for a proof-of-concept
implementation of python#2938 I am working on, which will want to
call into this code from build, and a build -> main dependency
seems wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msullivan @gvanrossum